Fixed ReflectionProperty::setValue() deprecation warning when working on PHP 8.3#979
Merged
othercorey merged 1 commit intocakephp:5.xfrom Dec 15, 2023
Merged
Conversation
Contributor
|
Thanks! We should backport this to 4.x. |
Contributor
Author
|
If needed I'll open another PR for it shortly
…On Fri, 15 Dec 2023, 19:20 othercorey, ***@***.***> wrote:
Thanks! We should backport this to 4.x.
—
Reply to this email directly, view it on GitHub
<#979 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALD2JF3F5PGDZO6BRQOWZLYJSIG5AVCNFSM6AAAAABAWZ26KSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJYGMYDONZZHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
If you can, that would be helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On PHP 8.3 you get this deprecation warning:
I've changed the deprecated method out with the correct method. All tests (non -skipped) pass, and I can't see any issues.